-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Upgrade to Asciidoctor Gradle JVM 3.0.0 #19953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Asciidoctor Gradle JVM 3.0.0 #19953
Conversation
|
The current errors should be fixed with #19952 once merged. I only realized later that this blocks the Asciidoctor upgrade. |
|
We should check if we need to tackle spring-io/spring-asciidoctor-extensions#21 before merging this. That issue was opened as a placeholder so it may be that the extensions are already AsciidoctorJ 2.0 compatible. |
|
Is there anything I can help with, @wilkinsona ? |
|
Thanks for the offer, @dreis2211. I think it's been taken care of thanks to @rwinch. I just need to double-check that I didn't break it when merging and then cut a release of the extensions. |
|
The extensions have been released and Boot's now using them. I think we should now be good-to-go on this one. |
|
The PDF generation failed when built locally. I think that's because we're using the configuration property JSON to generate the Asciidoc source. This makes the changes to use, for example, |
|
Interesting....I wonder why this didn't fail for me locally? I will take a look again. Sorry for the inconvenience. |
|
Pushed an updated version |
Hi,
this PR upgrades to
org.asciidoctor:asciidoctor-gradle-jvm:3.0.0and fixes related issues that prevented building the docs on that new version. This seems to overlap with #19785 so I've split the necessary commits.Let me know what you think.
Cheers,
Christoph