Skip to content

Conversation

@dreis2211
Copy link
Contributor

Hi,

this PR upgrades to org.asciidoctor:asciidoctor-gradle-jvm:3.0.0 and fixes related issues that prevented building the docs on that new version. This seems to overlap with #19785 so I've split the necessary commits.

Let me know what you think.
Cheers,
Christoph

@dreis2211
Copy link
Contributor Author

dreis2211 commented Jan 28, 2020

The current errors should be fixed with #19952 once merged. I only realized later that this blocks the Asciidoctor upgrade.

@wilkinsona
Copy link
Member

wilkinsona commented Jan 28, 2020

We should check if we need to tackle spring-io/spring-asciidoctor-extensions#21 before merging this. That issue was opened as a placeholder so it may be that the extensions are already AsciidoctorJ 2.0 compatible.

@dreis2211
Copy link
Contributor Author

Is there anything I can help with, @wilkinsona ?

@wilkinsona
Copy link
Member

Thanks for the offer, @dreis2211. I think it's been taken care of thanks to @rwinch. I just need to double-check that I didn't break it when merging and then cut a release of the extensions.

@wilkinsona
Copy link
Member

The extensions have been released and Boot's now using them. I think we should now be good-to-go on this one.

@wilkinsona
Copy link
Member

The PDF generation failed when built locally. I think that's because we're using the configuration property JSON to generate the Asciidoc source. This makes the changes to use, for example, &lt; rather than < have no effect. The &lt; has been replaced with < again by the time the Asciidoctor processing is performed. I think we may need to do some escaping of the description in SingleConfigurationTableEntry instead.

@dreis2211
Copy link
Contributor Author

dreis2211 commented Feb 12, 2020

Interesting....I wonder why this didn't fail for me locally? I will take a look again. Sorry for the inconvenience.

@dreis2211
Copy link
Contributor Author

Pushed an updated version

wilkinsona pushed a commit that referenced this pull request Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants